fix: fix write stream reconnection issue #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
requested review from
merlimat,
coderzc and
RobertIndie
as code owners
merlimat
reviewed
Sep 5, 2024
| addExposedPorts(OXIA_PORT, METRICS_PORT); | ||
| if (fixedServicePort) { | ||
| int freePort = findFreePort(); | ||
| addFixedExposedPort(freePort, OXIA_PORT); |
There was a problem hiding this comment.
Why exposing a fixed port? There is already a way to get the port with random number and use it outside the container (eg: getMappedPort(OXIA_PORT))
There was a problem hiding this comment.
because I wanna testing the client behaviour when server restart. existing mechanism will use different ports after restart the container. that will make the client can't reonnect to the server.
merlimat
approved these changes
Sep 5, 2024
mattisonchao
pushed a commit
to streamnative/oxia
that referenced
this pull request
Sep 20, 2024
Get rid of failed write-streams in Go client SDK. This is similar change to streamnative/oxia-java#180 in Java SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the current implementation didn't replace the failed stream to a new stream. that causes client constantly get exception when write data to server due to oxia server restart.
Modification
Others
I am considering the performance affection here, let us try improve in the future.